Archery Apprentice Documentation

LiveScoringViewModel Critical Analysis

5 min read

LiveScoringViewModel Critical Analysis

File: app/src/main/java/com/archeryapprentice/ui/roundScoring/LiveScoringViewModel.kt Current Size: 2,134 lines (down from 2,808) Baseline (CLAUDE.md): 1,753 lines Growth: +381 lines (+22% from baseline, -24% from peak) Analysis Date: October 4, 2025 Last Updated: October 9, 2025 Status: 🔄 IN PROGRESS - 68% Complete

Executive Summary

LiveScoringViewModel experienced explosive 60% growth (1,753 → 2,808 lines) due to tournament feature additions. Systematic refactoring is now 68% complete with 4 major extractions completed:

  • ✅ TournamentSyncService (556 lines)
  • ✅ ScoreConflictResolutionService (262 lines)
  • ✅ EndCompletionService (400 lines)
  • ✅ StateFlow Delegation (145 lines)

Total Extracted: 1,363 lines (49% of peak size) Current Status: 2,134 lines (24% reduction from peak) Target: ~1,900 lines (coordinator role) Remaining: 2 services (~350 lines)

Current Status: 2,134 lines (down from 2,808), 68% refactoring complete, 2 services remaining

Refactoring Progress

✅ Completed Extractions (4/6)

1. TournamentSyncService - 556 lines extracted (Oct 5) ✅

  • Firebase synchronization
  • Score queueing
  • Leaderboard management
  • Real-time state updates

2. ScoreConflictResolutionService - 262 lines extracted (Oct 2025) ✅

  • Conflict detection
  • Resolution strategies
  • Version management

3. EndCompletionService - 400 lines extracted (Oct 6) ✅

  • End finalization
  • Firebase submission
  • Retry logic with exponential backoff
  • Multi-participant completion checking

4. StateFlow Delegation - 145 lines removed (Oct 9) ✅

  • Removed duplicate StateFlows (syncStatus, tournamentRoundState)
  • Delegated observeTournamentRoundState() to service
  • Delegated updateTournamentRoundStatus() to service
  • Removed dead code (syncDetailedTournamentScores)

🔲 Remaining Extractions (2/6)

5. TournamentRoundLifecycleService - ~200 lines (TODO)

  • Round initialization
  • Completion handling
  • State transitions

6. StatisticsAggregationService - ~150 lines (TODO)

  • Real-time stats calculation
  • Leaderboard updates
  • Trend detection

Current Metrics

File Statistics (Updated Oct 9)

  • Total Lines: 2,134 (down from 2,808, -674 lines)
  • Lines Extracted: 1,363 lines (49% of peak)
  • Progress: 68% complete (4/6 extractions done)
  • Target: ~1,900 lines (coordinator role)
  • Remaining: ~234 lines to remove

Complexity Improvement

  • Before: 9.5/10 (CRITICAL)
  • Current: 6/10 (MODERATE) - Improving with each extraction
  • Target: 3/10 (ACCEPTABLE)

Root Cause Analysis: Why 60% Growth?

Tournament Feature Phases Added (Aug-Oct 2025)

PHASE 2.2: Real-Time Tournament Scoring

Lines Added: ~400 lines Features:

  • setupTournamentSync() - Firebase real-time listeners
  • syncTournamentScoresManually() - Manual sync on-demand
  • syncDetailedTournamentScores() - End-by-end sync
  • _incomingTournamentScores StateFlow
  • Score conflict detection system
  • _scoreConflicts StateFlow

PHASE 3.1: Live Leaderboard Integration

Lines Added: ~250 lines Features:

  • _liveLeaderboard StateFlow
  • leaderboardListenerJob cleanup
  • observeTournamentRoundState() - Round status tracking
  • _tournamentRoundState StateFlow
  • Leaderboard real-time updates

PHASE 4.1: Score Conflict Resolution

Lines Added: ~300 lines Features:

  • ScoreConflict data class with version tracking
  • ConflictResolutionStrategy enum
  • determineConflictResolution() - Strategy selection
  • resolveConflict() - Manual conflict resolution
  • dismissConflict() - Conflict dismissal
  • Enhanced error types with SyncErrorType enum
  • Retry mechanism with retry counts

PHASE 4+: Tournament Round Lifecycle

Lines Added: ~200 lines Features:

  • startTournamentRound() - Round start state management
  • pauseTournamentRound() - Round pause handling
  • completeTournamentRound() - Round completion sync
  • updateTournamentRoundStatus() - Status updates
  • roundStateListenerJob cleanup

Guest Ownership & Participant Tracking

Lines Added: ~150 lines Features:

  • _tournamentParticipants StateFlow
  • participantsListenerJob cleanup
  • Guest ownership indicators
  • Participant management sync

Total Tournament Features: ~1,300 lines (123% of baseline!)

No refactoring between phases!

Extraction Strategy Applied

Copy-Delegate-Validate Pattern (Proven 4/4 times)

Phase 1: Copy

  • Extract service interface and implementation
  • Copy methods and StateFlows to new service
  • Maintain original code in ViewModel

Phase 2: Delegate

  • ViewModel delegates to service via dependency injection
  • Route UI calls through service methods
  • Expose service StateFlows directly

Phase 3: Validate

  • Run full test suite
  • Verify no functionality regression
  • Remove original code only after validation

Success Rate: 100% (4/4 extractions successful)

Success Criteria Progress

Quantitative Metrics

  • TournamentSyncService extracted (556 lines) ✅
  • ScoreConflictResolutionService extracted (262 lines) ✅
  • EndCompletionService extracted (400 lines) ✅
  • StateFlow delegation complete (145 lines) ✅
  • TournamentRoundLifecycleService extracted (~200 lines) 🔲
  • StatisticsAggregationService extracted (~150 lines) 🔲
  • LiveScoringViewModel reduced to <1,900 lines (currently 2,134)
  • All 1,000+ existing tests pass ✅
  • Test coverage maintained >75% ✅
  • Performance within 5% of baseline ✅

Qualitative Goals

  • Clear service boundaries ✅
  • Tournament features isolated ✅
  • Conflict resolution testable independently ✅
  • Listener management simplified (in progress)
  • Statistics calculation isolated (TODO)
  • Code complexity dramatically reduced (68% done)

Architecture Validation

  • Each extracted service <500 lines ✅
  • Single responsibility per service ✅
  • Clear dependency injection ✅
  • Testability score >8/10 for extracted services ✅
  • Final ViewModel <1,900 lines (currently 2,134)

Remaining Work (1-2 Weeks)

Priority 4: TournamentRoundLifecycleService (~200 lines, 3 days)

Extract:

  • Round initialization logic
  • Completion handling
  • State transition management

Benefits:

  • Clear lifecycle management boundary
  • Easier testing of round states
  • Reduced ViewModel complexity

Priority 5: StatisticsAggregationService (~150 lines, 2 days)

Extract:

  • Real-time stats calculation
  • Leaderboard entry building
  • Trend detection

Benefits:

  • Isolated statistics logic
  • Performance optimization opportunities
  • Independent testing

Final Cleanup (3 days)

  • Consolidate remaining StateFlows
  • Remove any remaining dead code
  • Optimize method organization
  • Validate final line count target

Comparison to RoundViewModel Situation

Key Differences:

  1. ❌ RoundViewModel: 3 planning docs, ZERO work done
  2. ✅ LiveScoringViewModel: EXECUTING - 68% complete!

Critical Lesson:

EXECUTION > PLANNING

LiveScoringViewModel proved the approach works - execute incrementally, one service at a time.

Timeline to Completion

Week 1-2 (Oct 5-6): ✅ TournamentSyncService, ScoreConflictResolutionService - COMPLETE Week 3 (Oct 6): ✅ EndCompletionService - COMPLETE
Week 4 (Oct 9): ✅ StateFlow Delegation - COMPLETE Week 5 (TODO): 🔲 TournamentRoundLifecycleService + StatisticsAggregationService Week 6 (TODO): 🔲 Final cleanup and validation

Expected Completion: Mid-October 2025 Current Progress: 68% (ahead of schedule)

Conclusion

LiveScoringViewModel’s 60% growth represents a maintainability crisis requiring immediate intervention. The explosive growth from tournament feature additions (Phases 2.2-4.1) created a 12-domain god class spanning 2,808 lines.

Progress Update (Oct 9):

  • Extracted: 1,363 lines (49% of peak)
  • Current Size: 2,134 lines (24% reduction)
  • Completion: 68% (4/6 extractions done)
  • Remaining: 2 services (~350 lines)

Key Difference from RoundViewModel:

  • RoundViewModel: Planned but never executed
  • LiveScoringViewModel: ✅ EXECUTING - 68% complete with proven pattern

Timeline: 1-2 weeks to complete remaining extractions and reach ~1,900 line target.

Risk Level: LOW - Proven extraction pattern with 100% success rate (4/4)

Business Impact: HIGH - Prevents technical debt from blocking future tournament features and multi-device enhancements.

Analysis Date: October 4, 2025 Last Updated: October 9, 2025 Status: IN PROGRESS - 68% COMPLETE

Graph View