Archery Apprentice Documentation

data-layer-architecture

3 min read

Data Layer Architecture

Overview: Documentation of the Archery Apprentice data layer architecture evolution during KMP migration.

Week 3 Data Model Migration (Oct 22-25, 2025)

Models Migrated (768 lines to shared:data)

1. TournamentRound + TournamentRoundStatus (48 lines)

  • Location: shared/data/src/commonMain/kotlin/com/archeryapprentice/data/models/tournament/
  • Purpose: Tournament round instance data and lifecycle state
  • KMP Status: ✅ 100% compatible
  • Key Changes:
    • Replaced System.currentTimeMillis() with Clock.System.now().toEpochMilliseconds()
    • Removed Android-specific types

2. TournamentScore + ScoreSyncStatus (66 lines)

  • Location: shared/data/src/commonMain/kotlin/com/archeryapprentice/data/models/tournament/
  • Purpose: Score submission data and sync state
  • KMP Status: ✅ 100% compatible
  • Key Changes:
    • Removed Firebase @PropertyName annotations
    • KMP-compatible timestamp handling

3. EndScoreWithArrows + Statistics (203 lines)

  • Location: shared/data/src/commonMain/kotlin/com/archeryapprentice/data/models/
  • Types: EndScoreWithArrows, EndStatistics, RoundStatistics, AggregateStats, RoundTotals
  • Purpose: End-level scoring and aggregated statistics
  • KMP Status: ✅ 100% compatible
  • Key Changes:
    • Preserved all statistics calculations
    • KMP-compatible data structures

4. TournamentSettings (269 lines - Most Complex)

  • Location: shared/data/src/commonMain/kotlin/com/archeryapprentice/data/models/
  • Purpose: Tournament configuration and settings
  • KMP Status: ✅ 100% compatible
  • Key Challenges:
    • Date → kotlinx-datetime Instant conversion
    • Removed Android Parcelable dependencies
    • Updated BowType.values() to BowType.entries (modern Kotlin)
  • Complexity: 7 nested data classes + 5 enums + 4 extension functions
  • Impact: Updated 15+ repository/service files

5. Security Models (182 lines)

  • Location: shared/data/src/commonMain/kotlin/com/archeryapprentice/data/models/
  • Types: TournamentSecurity, SecurityEvent, SuspiciousActivityEvent
  • Purpose: Tournament security and event tracking
  • KMP Status: ✅ 100% compatible
  • Key Changes:
    • Split SecurityModels.kt: tournament security → shared:data, user privacy → app module
    • 4 enums: SecurityEventType, SecuritySeverity, SuspiciousActivityType, AutomaticAction

Repository Restoration (Days 6-7)

OfflineTournamentRepository Fully Restored

  • Restored From: Pre-stub version (commit 038d554)
  • Import Updates:
    • 40+ shared:domain imports (Week 2 migrations)
    • 10+ shared:data imports (Week 3 migrations)
  • Critical Fix: validateJoinCode implementation using Flow.first()
  • Test Failures Resolved: All 30 failures fixed
    • 27 OfflineTournamentRepositoryTest failures → All passing ✅
    • 3 HybridTournamentRepositoryTest failures → All passing ✅
  • Architecture: Offline-first architecture preserved (critical for local-first approach)

Migration Metrics

Lines Migrated: 768 lines across 5 major types KMP Compatibility: 100% (zero Android dependencies) Test Pass Rate: 100% (3,860+ tests) Regressions: ZERO

Import Updates:

  • Week 2 (shared:domain): 40+ imports updated
  • Week 3 (shared:data): 10+ imports updated
  • Total: 50+ systematic import corrections

Code Quality:

  • Consistent use of KMP-compatible types (kotlinx-datetime, Clock.System)
  • Systematic cleanup maintained
  • All Android-specific dependencies removed

Architecture Impact

KMP Readiness:

  • ✅ All 5 data model types now KMP-compatible (zero Android dependencies)
  • ✅ Offline repository functionality preserved (critical for local-first architecture)
  • ✅ Ready for iOS platform addition (data layer portable)

Code Health:

  • ✅ 768 lines migrated to shared code
  • ✅ Systematic import cleanup (50+ imports updated)
  • ✅ Consistent use of KMP-compatible types
  • ✅ Zero test regressions

Data Layer Structure:

  • Data models properly separated from domain models
  • Repository layer works with both shared:domain and shared:data types
  • Offline-first architecture preserved

Last Updated: 2025-10-25 Migration Status: Complete - Data layer 100% KMP compatible

Graph View