Archery Apprentice Documentation

December 2025 Development Backlog

3 min read

December 2025 Development Backlog

Comprehensive documentation of development work completed December 6-27, 2025. This period included major architectural improvements, security enhancements, and the iOS App Store submission preparation.

Summary

CategoryPRsImpact
God Class Refactoring357-3711,200+ lines extracted
Data Validation Guard Rails387-39123 vulnerabilities fixed
Build & Infrastructure374-37530% APK size reduction
iOS Bug Fixes#372Sync participant progress
Service Extractions392-393, #399400+ lines extracted
Dependency Updates#386, #400December consolidation
iOS App Store#401Legacy tournament fix

God Class Refactoring Campaign (Dec 6-14)

Major architectural improvements extracting services from god classes. See god-class-refactoring-campaign for full details.

PRs Merged

PRDateDescription
#357Dec 8FirebaseTournamentRepository test coverage
#358Dec 8Extract services from FirebaseTournamentRepository
#359Dec 8RoundDisplayService to RoundManagementViewModel
#369Dec 9Remove duplicate code from LiveScoringViewModel
#370Dec 9Extract TournamentRoundCreationService
#371Dec 14Extract ScoringViewModelDelegate from ActiveScoringScreen

Services Extracted

  • RoundDisplayService - Round display formatting and calculations
  • TournamentRoundCreationService - Round creation and validation
  • ScoringViewModelDelegate - Active scoring state management

Impact

  • LiveScoringViewModel: 2,016 → ~1,400 lines (31% reduction)
  • Test coverage improved from 45% → 78%
  • Cyclomatic complexity reduced from 25 → 12

iOS Fixes (Dec 15)

PRDescription
#372Sync participant progress from database on round load

Fixed issue where iOS wasn’t syncing participant progress from the database when loading existing rounds in multi-participant tournaments.

Build & Infrastructure (Dec 15)

PRDescription
#374Camera debug infrastructure for arrow detection
#375Reduce APK size and add native debug symbols

Camera Debug Infrastructure

Added debug-only features for camera arrow detection testing:

  • Detection metrics tracking (raw → confidence → NMS filtering)
  • Image picker from gallery for testing
  • Detection overlay with confidence-colored bounding boxes
  • Verbose logging for pipeline debugging

See camera-debug-infrastructure for details.

APK Size Optimization

  • Added ABI filters: arm64-v8a, armeabi-v7a only
  • Removed x86/x86_64 (emulator-only architectures)
  • Added native debug symbols for Google Play crash analysis
  • Result: ~30% APK size reduction

See apk-size-optimization for details.

Data Validation Guard Rails (Dec 22)

Complete 4-phase security implementation addressing 23 critical vulnerabilities. See data-validation-guard-rails for full details.

PRs Merged

PRPhaseDescription
#387SetupValidationConstants, DEV_ENV setup guide
#3881ValidationPatterns, ValidationRules
#3892Presenter & ViewModel validation layer
#3903UI Layer maxLength constraints
#3914InputSanitizer, cross-field, password strength

Components Created

  • ValidationConstants.kt - All validation limits
  • ValidationPatterns.kt - Regex patterns for format validation
  • ValidationRules.kt - Validation functions with error messages
  • InputSanitizer.kt - XSS prevention, HTML stripping

Vulnerabilities Fixed

CategoryCountMitigation
Unlimited text fields12Length limits
Unbounded numeric inputs8Range validation
Missing format validation3Regex patterns

Service Extractions (Dec 21-26)

Additional service extractions from TournamentDetailsViewModel:

PRServiceDescription
#392CreatorAuthorizationServiceTournament creator authorization checks
#393Branch coverage followupAdditional tests for CreatorAuthorizationService
#399TournamentParticipationServiceSelf-validating join/leave operations

CreatorAuthorizationService

Centralized authorization logic for tournament creators:

  • isCurrentUserCreator(tournamentId)
  • canModifyTournament(tournamentId)
  • canManageParticipants(tournamentId)
  • canDeleteTournament(tournamentId)

TournamentParticipationService

Self-validating participation operations:

  • joinTournament(tournamentId, participant)
  • leaveTournament(tournamentId, participantId)
  • validateJoinRequest(tournament, participant)

Dependency Updates (Dec 22)

PRDescription
#386Consolidated dependency updates (December 2025)
#400Additional dependency updates

Monthly dependency consolidation following the established dependency policy.

iOS App Store Submission (Dec 27)

PRDescription
#401Fix empty participants list for legacy tournaments

Critical bug fix blocking iOS App Store submission. See 2025-12-27-ios-app-store-submission for full session log.

Problem

Legacy tournaments showed “7/8” participant count but empty participants list.

Root Cause

  • Legacy tournaments have participantIds array but empty participants subcollection
  • Participant loading only checked subcollection

Solution

  • Fallback loading: When subcollection empty, load from array
  • Background repair: Populate subcollection for future loads
  • DisplayNameResolver: Consistent display name resolution

Files Changed

  • DisplayNameResolver.kt (new)
  • FirebaseParticipantService.kt (Android)
  • TournamentDetailViewModel.swift (iOS)

Test Coverage Summary

ComponentCoverage
ValidationRules100%
ValidationPatterns100%
InputSanitizer100%
DisplayNameResolver100%
CreatorAuthorizationService100%
TournamentParticipationService92%
CameraDebugFeatureFlags100%
Overall Project84%

Documentation Created

DocumentLocation
Data Validation Guard Railsdeveloper-guide/architecture/data-validation-guard-rails.md
God Class Refactoring Campaigndeveloper-guide/architecture/god-class-refactoring-campaign.md
Camera Debug Infrastructuredeveloper-guide/guides/camera-debug-infrastructure.md
APK Size Optimizationdeveloper-guide/guides/apk-size-optimization.md
iOS App Store Sessioninternal/sessions/2025-12-27-ios-app-store-submission.md

Next Steps

  1. Merge PR #401 → App Store submission
  2. iOS App Store Review → Expected 24-48 hours
  3. HybridTournamentRepository Split → Planned for January

Graph View